Forum Discussion

scaper12123's avatar
scaper12123
Visitor
9 years ago

can xml reference functions outside of xml?

I have a function I use to record time that I want to reference in an xml document I'm using to create a countdown timer. Is the code within the xml document capable of recognizing that I am referencing a function within my primary brightscript documents, or do I have to do something special to point that fact out?

to clarify, I have this in the xml document
      sub changeTime(seconds as integer)
        m.label.text = CountdownTime(seconds)
        return
      end sub


And I have this in a brs document
function CountdownTime(seconds as integer) as string
    h = seconds / 3600
    m = (seconds - h * 3600) / 60
    s = seconds Mod 60
    Return h.ToStr() + ":" + Right("0" + m.ToStr(), 2) + ":" + Right("0" + s.ToStr(), 2)
end function
Roku Developer Program

16 Replies

  • belltown's avatar
    belltown
    Roku Guru
    9 years ago
    I can't help you with the scene graph stuff, but I can tell you that the time formatting code of mine that you copied and changed has two fundamental flaws: you're using dynamic types instead of declared types, so you'll end up with floating values instead of integer values when you divide; and you're using "m", the global BrightScript "this" pointer, as your minutes variable, which will play havoc with anything else in your code that references "m".

    Here's the original code:

    ' Format the time left: "h:mm:ss"
    Function formatTimeLeft (seconds As Integer) As String
        h% = seconds / 3600
        m% = (seconds - h% * 3600) / 60
        s% = seconds Mod 60
        Return h%.ToStr () + ":" + Right ("0" + m%.ToStr (), 2) + ":" + Right ("0" + s%.ToStr (), 2)
    End Function
  • scaper12123's avatar
    scaper12123
    Visitor
    9 years ago
    "belltown" wrote:
    I can't help you with the scene graph stuff, but I can tell you that the time formatting code of mine that you copied and changed has two fundamental flaws: you're using dynamic types instead of declared types, so you'll end up with floating values instead of integer values when you divide; and you're using "m", the global BrightScript "this" pointer, as your minutes variable, which will play havoc with anything else in your code that references "m".

    Oh! Well... hmm... it's a good thing I hadn't referenced that code in my current implementation! Haha. I rewrote it assuming that the % objects didn't actually matter and were just some writing convention you were using. Thank you for correcting me on that front.
  • EnTerr's avatar
    EnTerr
    Roku Guru
    9 years ago
    Eh, you can always fix() it. And let me use an obscure function for no raisin:
    ' Format the time left: "h:mm:ss"'
    function formatTimeLeft(secs as Integer):
        hrs = seconds\3600           ''or fix(seconds/3600)
        mins = seconds\60 - 60*hrs   ''or fix(seconds/60) - 60*hrs
        return substitute("^0:^1:^2", hrs.toStr(), right("0"+mins.toStr(), 2), right("0"+(secs mod 60).toStr(), 2)
    end function

    The main question however remains...

    PS. updated to use int division as reminded by RokuKC
  • scaper12123's avatar
    scaper12123
    Visitor
    9 years ago
    "EnTerr" wrote:
    Eh, you can always fix() it. And let me use an obscure function for no raisin:
    ' Format the time left: "h:mm:ss"
    function formatTimeLeft(secs as Integer):
        hrs = fix(seconds/3600)
        mins = fix(seconds/60) - 60*hrs
        return substitute("^0:^1:^2", hrs.toStr(), right("0"+mins.toStr(), 2), right("0"+(secs mod 60).toStr(), 2)
    end function

    The main question however remains...

    I just continue to rack up the questions, myself. Like now I can't seem to call the screen up at all because I call a function that displays and changes the time, and then it crashes as soon as i try to do a single arithmetic problem. I can't tell what the problem is with that.
  • RokuKC's avatar
    RokuKC
    Roku Employee
    9 years ago
    "EnTerr" wrote:
    Eh, you can always fix() it. And let me use an obscure function for no raisin:


    Maybe it's less readable to non-BrightScript experts, but I would just use the integer division operator \ instead.
  • belltown's avatar
    belltown
    Roku Guru
    9 years ago
    "RokuKC" wrote:
    "EnTerr" wrote:
    Eh, you can always fix() it. And let me use an obscure function for no raisin:


    Maybe it's less readable to non-BrightScript experts, but I would just use the integer division operator \ instead.

    I didn't even know that existed. Good to know.
  • scaper12123's avatar
    scaper12123
    Visitor
    9 years ago
    "belltown" wrote:
    "RokuKC" wrote:
    "EnTerr" wrote:
    Eh, you can always fix() it. And let me use an obscure function for no raisin:


    Maybe it's less readable to non-BrightScript experts, but I would just use the integer division operator \ instead.

    I didn't even know that existed. Good to know.

    I'm glad this dilemma was helpful for you XD
  • EnTerr's avatar
    EnTerr
    Roku Guru
    9 years ago
    "RokuKC" wrote:
    Maybe it's less readable to non-BrightScript experts, but I would just use the integer division operator \ instead.

    I would have, if i could remember it is "\". Today I pondered for a moment if int division was added at some point, even tried "div" and "//" but no dice. Somewhat embarrassing really... 
  • TheEndless's avatar
    TheEndless
    Channel Surfer
    9 years ago
    "EnTerr" wrote:
    "RokuKC" wrote:
    Maybe it's less readable to non-BrightScript experts, but I would just use the integer division operator \ instead.

    I would have, if i could remember it is "\". Today I pondered for a moment if int division was added at some point, even tried "div" and "//" but no dice. Somewhat embarrassing really... 

    If it makes you feel any better, I don't think it was added until 7.0.  And I'm sure you'll find some joy in the fact that the Eclipse plugin still doesn't recognize it as valid syntax...
  • EnTerr's avatar
    EnTerr
    Roku Guru
    9 years ago
    "TheEndless" wrote:
    "EnTerr" wrote:
    I would have, if i could remember it is "\". Today I pondered for a moment if int division was added at some point, even tried "div" and "//" but no dice. Somewhat embarrassing really... 

    If it makes you feel any better, I don't think it was added until 7.0.

    1.5 years ago actually, together with << and >>.  Hindsight 20/20

    And I'm sure you'll find some joy in the fact that the Eclipse plugin still doesn't recognize it as valid syntax...

    Umm... who? [spoiler=star-lord:ydpytikf][youtube:ydpytikf]vWh6VllqX_4[/youtube:ydpytikf][/spoiler:ydpytikf]
    Speaking of which, didn't RokuCo hire someone to write a proper IDE last year? I seem to recollect there was job posting on that which is gone now. So by deduction, one would expect that turd be gone soon?