saving variable.

There are two ways to share a variable between two functions. The preferred way is to have the first function pass the variable as a parameter to the second function. You can also store the variable in the global AA but this can get messy if you have many variables to share.

--Mark

"RokuMarkn" wrote:
There are two ways to share a variable between two functions. The preferred way is to have the first function pass the variable as a parameter to the second function. You can also store the variable in the global AA but this can get messy if you have many variables to share.

--Mark

Thank you Mark. That makes sense to me. The problem is trying to find somewhere that explains how to do this. If you search the Wiki for "variable as a parameter" or "stored in variables" or "function pass" you get search results that point you to the Brightscript language reference which just says that yes, functions exist and can be stored in variables and passed to functions. So how? Can you point to an SDK example of where this is happening? I have made functions and used them so I've gotten that far at least.

thanks

Well, there are many examples of passing parameters in the SDK examples. Basically you declare the variables within the parentheses in your function definition, and then you put the variable you want to pass in parentheses when you call the function.

function First()
    ....
    curr_photo = photolist[onscreenphoto]
    ....
    DisplayDialog(curr_photo)
    ....
end function

function DisplayDialog(photo as Object)
    title = photo.GetTitle()
    ....
end function

Note that the variable name doesn't need to be the same in the calling function as the called function, but it can be the same if you want.

--Mark

I really appreciate your help, so far its not taking.

I'm using two functions I know you are familiar with, here are the relevant parts. I believe the first function is set up as you explained - the variable is defined (curr_photo) and then used.

Sub DisplaySlideShow(slideshow, photolist)

.........
    		else if msg.isPlaybackPosition() then
    		onscreenphoto = msg.GetIndex()
    		curr_photo = photolist[onscreenphoto]
			print "slideshow display: " + Stri(msg.GetIndex())

.........
canvas = CreateObject( "roImageCanvas" )
    					fontReg = CreateObject("roFontRegistry")
						fontReg.Register("pkg:/fonts/caps.otf")
						font = fontReg.Get("caps",28,50,true)

    bgRect = {
        Color: "#00000000",
        TargetRect: { x: 55, y: 10, w: 280, h: 50 }
    }
    text = {
        Text: curr_photo.GetTitle(),
        TextAttrs:{Color:"#960404", Font:font,
        HAlign:"Left", VAlign:"VCenter", Direction:"LeftToRight"}

		TargetRect: bgRect.TargetRect
    }
 	canvas.SetLayer( 0, [ bgRect, text ] )
 				
    canvas.Show()
    Sleep( 2500 )
    canvas.Close()

End Sub

Now here is where i lose it, The function that is receiving the passed variable you have as

function DisplayDialog(photo as Object)
    title = photo.GetTitle()
    ....
end function

1. the var I'm looking for is curr_photo not photo. photo.GetTitle() returns the wrong result as you fixed here:http://forums.roku.com/viewtopic.php?f=34&t=55984 (which is how i got curr_photo in the first place)

2.I'm trying to pass this variable to an existing function you will also recognize:

Function DisplayInfomenu(infotype)

	
	infomenu = createobject("romessagedialog")
	infomenu.setmessageport(createobject("romessageport"))
	infomenu.enableoverlay(true)

	if (infotype = 0)
		infomenu.setTitle(curr_photo.GetTitle) ' This is how I think this should be. wont work till i solve the var/pass thing.
		infomenu.setTitle("Title Here") ' The normal way
                infomenu.settext("bla blah")
		infomenu.addbutton(3,"Music")
		infomenu.addbutton(13,"Next")
	'	infomenu.addbutton(4,"Done")
		infomenu.setfocusedmenuitem(1)		' 2nd button

.........
Trying to match your example DisplayInfomenu(infotype) already has a parameter so:
DisplayInfomenu(photo as Object, infotype)
DisplayInfomenu(infotype, photo as Object)
DisplayInfomenu([photo as Object, infotype])

All error

Also trying to add
title= photo.GetTitle() or
title = curr_photo.GetTitle
to the beginning of that function throw dot operator errors.

I was able to figure out where the curr_photo thing went when you wrote it in the other thread, but this is not as simple.

Ok did this all day and got nowhere.
If i understand correctly in your example:

DisplayDialog(curr_photo)

or in my case

DisplayInfomenu(curr_photo)

goes at the end of the first sub and is the line that is passing the variable curr_photo to the function DisplayInfoMenu()

I am stuck at the syntax for the parameters of the function DisplayInfoMenu(infotype, ???) Already has infotype, how do i fit "photo as object" in.

Also no matter what i did (tried a hundred ways) curr_photo always showed as uninitialized in the debugger.

thanks

If you have two parameters, they are separated by a comma in the call and also separated by a comma in the function definition.

function DisplayInfoMenu(infotype as Object, curr_photo as Object)
    title = curr_photo.GetTitle()
end function

function DisplaySlideShow()
   DisplayInfoMenu(infotype, curr_photo)
end function

I've changed the name of the parameter to curr_photo because it was confusing you, but it doesn't matter. Each function has its own set of variables. Even if some have the same name as variables in other functions, they are different variables. So the curr_photo (or photo) in DisplayInfoMenu is a different variable than any variable in DisplaySlideShow, except for the fact that you passed two of the variables.

I've also added types to the parameters ("as Object") even though you weren't using a type previously. It's not necessary, but it's good practice that can help you catch errors earlier.

--Mark

Thank you Mark for bringing some progress to an otherwise frustrating day. I'm close to being able to say success instead of progress.
What you are saying is clear and I am getting a much better understanding. Ironically, I'm back at the same results you fixed before - returning the last item in the array instead of the current one, but this time i can see why.
Here is the slideshow sub - curr_photo is defined, then used (returning correct results) in the canvas, then passed on at the end.

Sub DisplaySlideShow(slideshow, photolist)

.......................	

	else if msg.isPlaybackPosition() then
    		onscreenphoto = msg.GetIndex()
    		curr_photo = photolist[onscreenphoto]
			print "slideshow display: " + Stri(msg.GetIndex())
			
	canvas = CreateObject( "roImageCanvas" )
    					fontReg = CreateObject("roFontRegistry")
						fontReg.Register("pkg:/fonts/caps.otf")
						font = fontReg.Get("caps",28,50,true)

    bgRect = {
        Color: "#00000000",
        TargetRect: { x: 55, y: 10, w: 280, h: 50 }
    }
    text = {
        Text: curr_photo.GetTitle(),
        TextAttrs:{Color:"#960404", Font:font,
        HAlign:"Left", VAlign:"VCenter", Direction:"LeftToRight"}

		TargetRect: bgRect.TargetRect
    }
 	canvas.SetLayer( 0, [ bgRect, text ] )
 				
    canvas.Show()
    Sleep( 2500 )
    canvas.Close()
    
     else if msg.isRemoteKeyPressed()
               if msg.GetIndex() = 10
                DisplayInfoMenu(6, photo) ' Problem Line Here?
                end if
    
..........................

	DisplayInfomenu(infotype, curr_photo)

End Sub

Here is the Infomenu function:

  Function DisplayInfomenu(infotype as Object, curr_photo as Object)
	infomenu = createobject("romessagedialog")
	infomenu.setmessageport(createobject("romessageport"))
	infomenu.enableoverlay(true)
	if (infotype = 6)
	infomenu.setTitle(curr_photo.GetTitle())
................
	

This works, showing a Title in the info dialog - however it returns the last item in the array, not the current one, not too surprising since the variable used below is photo not curr_photo

else if msg.isRemoteKeyPressed()
               if msg.GetIndex() = 10
                DisplayInfoMenu(6, photo) ' Problem Line Here?
                end if

what seems strange is that if I change it to what it should be:

DisplayInfoMenu(6, curr_photo)

I get a type mismatch on the first line of the infomenu function

311: end function
Type Mismatch. (runtime error &h18) in ...g:/source/mediarsstoolkit.brs(261)

261:   Function DisplayInfomenu(infotype as Object, curr_photo as Object)

..........................

infotype &h0010 bsc:roInt, refcnt=1
curr_photo &h0000 <uninitialized> val:Uninitialized
global   &h0020 rotINTERFACE:ifGlobal
m        &h0010 bsc:roAssociativeArray, refcnt=4

with curr_photo showing as uninitialized.
I smell some sort of syntax fix but I'm stumped right now. Thanks to you I got somewhere today and will try again in the morning. I really appreciate the chance to learn.

Well, that could happen if you press a button and get an isRemoteKeyPressed event before the slide show delivers the first isPlaybackPosition event, since that's the only place that curr_photo gets initialized. If you don't see how that could be happening, I would add a print statement where you set curr_photo and see if it's being executed.

--Mark

"RokuMarkn" wrote:
Well, that could happen if you press a button and get an isRemoteKeyPressed event before the slide show delivers the first isPlaybackPosition event, since that's the only place that curr_photo gets initialized. If you don't see how that could be happening, I would add a print statement where you set curr_photo and see if it's being executed.

--Mark

That makes sense except that the IsRemotekeyPressed is after where its initialized and after where its used (canvas). I added (same as previous) two lines to the RemoteKey block and now It works with curr_photo except it pulls the 11th item in the array. I feel like I'm getting closer.The fact that the canvas uses the curr_photo correctly seems to indicate it is being executed, and that does happen before the RemoteKeyPressed.

onscreenphoto = msg.GetIndex()
curr_photo = photolist[onscreenphoto]

else if msg.isPlaybackPosition() then
    		onscreenphoto = msg.GetIndex()
    		curr_photo = photolist[onscreenphoto]
			print "slideshow display: " + Stri(msg.GetIndex())
			
		
    				
    canvas = CreateObject( "roImageCanvas" )
    					fontReg = CreateObject("roFontRegistry")
						fontReg.Register("pkg:/fonts/caps.otf")
						font = fontReg.Get("caps",28,50,true)

    bgRect = {
        Color: "#00000000",
        TargetRect: { x: 55, y: 10, w: 280, h: 50 }
    }
    text = {
        Text: curr_photo.GetTitle(),
        TextAttrs:{Color:"#960404", Font:font,
        HAlign:"Left", VAlign:"VCenter", Direction:"LeftToRight"}

		TargetRect: bgRect.TargetRect
    }
 	canvas.SetLayer( 0, [ bgRect, text ] )
 				
    canvas.Show()
    Sleep( 2500 )
    canvas.Close()
    
     else if msg.isRemoteKeyPressed()
   			onscreenphoto = msg.GetIndex()
    		curr_photo = photolist[onscreenphoto]
               if msg.GetIndex() = 10
                DisplayInfomenu(6, curr_photo)
                end if

Added print curr_photo to the block where its initialized and get this back for each slide while the canvas shows the proper title.

gettitle:<bsTypedValue: Function>
http: <Component: roUrlTransfer>
xml: <Component: roXMLElement>
geturl: <bsTypedValue: Function>

also same result adding print cur_photo to the RemoteKey pressed block


thanks